Commit 3574c322 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: use optimized mballoc scanning regardless of inode format 



Currently we don't used mballoc optimized scanning (using max free
extent order and avg free extent order group lists) for inodes with
indirect block based format. This is confusing for users and I don't see
a good reason for that. Even with indirect block based inode format we
can spend big amount of time searching for free blocks for large
filesystems with fragmented free space. To add to the confusion before
commit 077d0c2c ("ext4: make mb_optimize_scan performance mount
option work with extents") optimized scanning was applied *only* to
indirect block based inodes so that commit appears as a performance
regression to some users. Just use optimized scanning whenever it is
enabled by mount options.

Reviewed-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Cc: stable@kernel.org
Link: https://patch.msgid.link/20260114182836.14120-4-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 4865c768

fs/ext4/mballoc.c

+0 −2
Original line number Diff line number Diff line
@@ -1148,8 +1148,6 @@ static inline int should_optimize_scan(struct ext4_allocation_context *ac) 
		return 0;

	if (ac->ac_criteria >= CR_GOAL_LEN_SLOW)

		return 0;

	if (!ext4_test_inode_flag(ac->ac_inode, EXT4_INODE_EXTENTS))

		return 0;

	return 1;

}