Commit 35bf430e authored by Henry Huang's avatar Henry Huang Committed by Tejun Heo
Browse files

sched_ext: initialize kit->cursor.flags 



struct bpf_iter_scx_dsq *it maybe not initialized.
If we didn't call scx_bpf_dsq_move_set_vtime and scx_bpf_dsq_move_set_slice
before scx_bpf_dsq_move, it would cause unexpected behaviors:
1. Assign a huge slice into p->scx.slice
2. Assign a invalid vtime into p->scx.dsq_vtime

Signed-off-by: default avatarHenry Huang <henry.hj@antgroup.com>
Fixes: 6462dd53 ("sched_ext: Compact struct bpf_iter_scx_dsq_kern")
Cc: stable@vger.kernel.org # v6.12
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 18b2093f

kernel/sched/ext.c

+1 −1
Original line number Diff line number Diff line
@@ -7013,7 +7013,7 @@ __bpf_kfunc int bpf_iter_scx_dsq_new(struct bpf_iter_scx_dsq *it, u64 dsq_id, 
		return -ENOENT;



	INIT_LIST_HEAD(&kit->cursor.node);

	kit->cursor.flags |= SCX_DSQ_LNODE_ITER_CURSOR | flags;

	kit->cursor.flags = SCX_DSQ_LNODE_ITER_CURSOR | flags;

	kit->cursor.priv = READ_ONCE(kit->dsq->seq);



	return 0;