Commit 361acaca authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci: Remove BUG() when Ring Abort request times out 



Ring Abort request will timeout in case there is an error in the Host
Controller interrupt delivery or Ring Header configuration. Using BUG()
makes hard to debug those cases.

Make it less severe and turn BUG() to WARN_ON().

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20230921055704.1087277-6-jarkko.nikula@linux.intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 45a832f9

drivers/i3c/master/mipi-i3c-hci/dma.c

+1 −2
Original line number Diff line number Diff line
@@ -450,10 +450,9 @@ static bool hci_dma_dequeue_xfer(struct i3c_hci *hci, 
		/*

		 * We're deep in it if ever this condition is ever met.

		 * Hardware might still be writing to memory, etc.

		 * Better suspend the world than risking silent corruption.

		 */

		dev_crit(&hci->master.dev, "unable to abort the ring\n");

		BUG();

		WARN_ON(1);

	}



	for (i = 0; i < n; i++) {