Commit 3652117f authored by Christian Brauner's avatar Christian Brauner
Browse files

eventfd: simplify eventfd_signal() 

Ever since the eventfd type was introduced back in 2007 in commit
e1ad7468 ("signal/timer/event: eventfd core") the eventfd_signal()
function only ever passed 1 as a value for @n. There's no point in
keeping that additional argument.

Link: https://lore.kernel.org/r/20231122-vfs-eventfd-signal-v2-2-bd549b14ce0c@kernel.org


Acked-by: default avatarXu Yilun <yilun.xu@intel.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com> # ocxl
Acked-by: Eric Farman <farman@linux.ibm.com>  # s390
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 85884871

arch/x86/kvm/hyperv.c

+1 −1
Original line number Diff line number Diff line
@@ -2388,7 +2388,7 @@ static u16 kvm_hvcall_signal_event(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *h 
	if (!eventfd)

		return HV_STATUS_INVALID_PORT_ID;



	eventfd_signal(eventfd, 1);

	eventfd_signal(eventfd);

	return HV_STATUS_SUCCESS;

}

arch/x86/kvm/xen.c

+1 −1
Original line number Diff line number Diff line
@@ -2088,7 +2088,7 @@ static bool kvm_xen_hcall_evtchn_send(struct kvm_vcpu *vcpu, u64 param, u64 *r) 
		if (ret < 0 && ret != -ENOTCONN)

			return false;

	} else {

		eventfd_signal(evtchnfd->deliver.eventfd.ctx, 1);

		eventfd_signal(evtchnfd->deliver.eventfd.ctx);

	}



	*r = 0;

drivers/accel/habanalabs/common/device.c

+1 −1
Original line number Diff line number Diff line
@@ -2044,7 +2044,7 @@ static void hl_notifier_event_send(struct hl_notifier_event *notifier_event, u64 
	notifier_event->events_mask |= event_mask;



	if (notifier_event->eventfd)

		eventfd_signal(notifier_event->eventfd, 1);

		eventfd_signal(notifier_event->eventfd);



	mutex_unlock(&notifier_event->lock);

}

drivers/fpga/dfl.c

+1 −1
Original line number Diff line number Diff line
@@ -1872,7 +1872,7 @@ static irqreturn_t dfl_irq_handler(int irq, void *arg) 
{

	struct eventfd_ctx *trigger = arg;



	eventfd_signal(trigger, 1);

	eventfd_signal(trigger);

	return IRQ_HANDLED;

}

drivers/gpu/drm/drm_syncobj.c

+3 −3
Original line number Diff line number Diff line
@@ -1365,7 +1365,7 @@ static void syncobj_eventfd_entry_fence_func(struct dma_fence *fence, 
	struct syncobj_eventfd_entry *entry =

		container_of(cb, struct syncobj_eventfd_entry, fence_cb);



	eventfd_signal(entry->ev_fd_ctx, 1);

	eventfd_signal(entry->ev_fd_ctx);

	syncobj_eventfd_entry_free(entry);

}
@@ -1388,13 +1388,13 @@ syncobj_eventfd_entry_func(struct drm_syncobj *syncobj, 
	entry->fence = fence;



	if (entry->flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE) {

		eventfd_signal(entry->ev_fd_ctx, 1);

		eventfd_signal(entry->ev_fd_ctx);

		syncobj_eventfd_entry_free(entry);

	} else {

		ret = dma_fence_add_callback(fence, &entry->fence_cb,

					     syncobj_eventfd_entry_fence_func);

		if (ret == -ENOENT) {

			eventfd_signal(entry->ev_fd_ctx, 1);

			eventfd_signal(entry->ev_fd_ctx);

			syncobj_eventfd_entry_free(entry);

		}

	}