Commit 3653fc1b authored by Zi Yan's avatar Zi Yan Committed by Andrew Morton
Browse files

mm/huge_memory: remove after_split label in __split_unmapped_folio() 

Check stop_split instead to avoid the goto statement.

Link: https://lkml.kernel.org/r/20250718183720.4054515-3-ziy@nvidia.com


Signed-off-by: default avatarZi Yan <ziy@nvidia.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarLorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Antonio Quartulli <antonio@mandelbit.com>
Cc: Balbir Singh <balbirs@nvidia.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Barry Song <baohua@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kirill A. Shutemov <k.shutemov@gmail.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Mariano Pache <npache@redhat.com>
Cc: Mathew Brost <matthew.brost@intel.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 6c7de9c8

mm/huge_memory.c

+6 −6
Original line number Diff line number Diff line
@@ -3463,18 +3463,18 @@ static int __split_unmapped_folio(struct folio *folio, int new_order, 
				if (xas_error(xas)) {

					ret = xas_error(xas);

					stop_split = true;

					goto after_split;

				}

			}

		}



		if (!stop_split) {

			folio_split_memcg_refs(folio, old_order, split_order);

			split_page_owner(&folio->page, old_order, split_order);

			pgalloc_tag_split(folio, old_order, split_order);



			__split_folio_to_order(folio, old_order, split_order);

		}



after_split:

		/*

		 * Iterate through after-split folios and update folio stats.

		 * But in buddy allocator like split, the folio