Commit 3664706e authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Tzung-Bi Shih
Browse files

power: supply: cros_charge-control: don't load if Framework control is present 



Framework laptops implement a custom charge control EC command.
The upstream CrOS EC command is also present and functional but can get
overridden by the custom one.

Until Framework make both commands compatible or remove their custom
one, don't load the driver on those machines.

If the user knows they are not going to use the custom command they can
use a module parameter to load cros_charge-control anyways.

Note that the UEFI setup configuration for battery control also uses
their custom command.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20240630-cros_ec-charge-control-v5-5-8f649d018c52@weissschuh.net


Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent c6ed48ef

drivers/power/supply/cros_charge-control.c

+22 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
 */

#include <acpi/battery.h>

#include <linux/container_of.h>

#include <linux/dmi.h>

#include <linux/mod_devicetable.h>

#include <linux/module.h>

#include <linux/platform_data/cros_ec_commands.h>
@@ -256,6 +257,19 @@ static int cros_chctl_remove_battery(struct power_supply *battery, struct acpi_b 
	return 0;

}



static bool probe_with_fwk_charge_control;

module_param(probe_with_fwk_charge_control, bool, 0644);

MODULE_PARM_DESC(probe_with_fwk_charge_control,

		 "Probe the driver in the presence of the custom Framework EC charge control");



static int cros_chctl_fwk_charge_control_versions(struct cros_ec_device *cros_ec)

{

	if (!dmi_match(DMI_SYS_VENDOR, "Framework"))

		return 0;



	return cros_ec_get_cmd_versions(cros_ec, 0x3E03 /* FW_EC_CMD_CHARGE_LIMIT */);

}



static int cros_chctl_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;
@@ -265,6 +279,14 @@ static int cros_chctl_probe(struct platform_device *pdev) 
	size_t i;

	int ret;



	ret = cros_chctl_fwk_charge_control_versions(cros_ec);

	if (ret < 0)

		return ret;

	if (ret > 0 && !probe_with_fwk_charge_control) {

		dev_info(dev, "Framework charge control detected, preventing load\n");

		return -ENODEV;

	}



	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);

	if (!priv)

		return -ENOMEM;