Commit 3667a35a authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Borislav Petkov (AMD)
Browse files

EDAC/device: Remove edac_dev_sysfs_block_attribute::{block,value} 

They're unused. And they were never used since their addition in

  fd309a9d ("drivers/edac: fix leaf sysfs attribute")

Drop it.

Found by https://github.com/jirislaby/clang-struct

.

Signed-off-by: default avatarJiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240213112051.27715-3-jirislaby@kernel.org


Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
parent f5ca0d51

drivers/edac/edac_device.c

+0 −2
Original line number Diff line number Diff line
@@ -162,8 +162,6 @@ edac_device_alloc_ctl_info(unsigned pvt_sz, char *dev_name, unsigned nr_instance 
				attrib->show = attrib_spec[attr].show;

				attrib->store = attrib_spec[attr].store;



				attrib->block = blk;	/* up link */



				edac_dbg(4, "alloc-attrib=%p attrib_name='%s' attrib-spec=%p spec-name=%s\n",

					 attrib, attrib->attr.name,

					 &attrib_spec[attr],

drivers/edac/edac_device.h

+0 −6
Original line number Diff line number Diff line
@@ -99,18 +99,12 @@ struct edac_dev_sysfs_attribute { 
 *	can have an array of the following. The show and store functions

 *	will be filled in with the show/store function in the

 *	low level driver.

 *

 *	The 'value' field will be the actual value field used for

 *	counting

 */

struct edac_dev_sysfs_block_attribute {

	struct attribute attr;

	ssize_t (*show)(struct kobject *, struct attribute *, char *);

	ssize_t (*store)(struct kobject *, struct attribute *,

			const char *, size_t);

	struct edac_device_block *block;



	unsigned int value;

};



/* device block control structure */