Commit 366f0a30 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans de Goede
Browse files

platform/surface: aggregator: fix a bit test 



The "funcs" variable is a u64.  If "func" is more than 31 then the
BIT() shift will wrap instead of testing the high bits.

Fixes: c167b9c7 ("platform/surface: Add Surface Aggregator subsystem")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/YH6UUhJhGk3mk13b@mwanda


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent dd5566d6

drivers/platform/surface/aggregator/controller.c

+1 −1
Original line number Diff line number Diff line
@@ -1040,7 +1040,7 @@ static int ssam_dsm_load_u32(acpi_handle handle, u64 funcs, u64 func, u32 *ret) 
	union acpi_object *obj;

	u64 val;



	if (!(funcs & BIT(func)))

	if (!(funcs & BIT_ULL(func)))

		return 0; /* Not supported, leave *ret at its default value */



	obj = acpi_evaluate_dsm_typed(handle, &SSAM_SSH_DSM_GUID,