Commit 3671411e authored by Johan Hovold's avatar Johan Hovold Committed by Bartosz Golaszewski
Browse files

gpio: mpsse: drop redundant device reference 



Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarLinus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260305124945.10781-1-johan@kernel.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
parent b678676b

drivers/gpio/gpio-mpsse.c

+1 −12
Original line number Diff line number Diff line
@@ -548,13 +548,6 @@ static void gpio_mpsse_ida_remove(void *data) 
	ida_free(&gpio_mpsse_ida, priv->id);

}



static void gpio_mpsse_usb_put_dev(void *data)

{

	struct mpsse_priv *priv = data;



	usb_put_dev(priv->udev);

}



static int mpsse_init_valid_mask(struct gpio_chip *chip,

				 unsigned long *valid_mask,

				 unsigned int ngpios)
@@ -598,11 +591,7 @@ static int gpio_mpsse_probe(struct usb_interface *interface, 


	INIT_LIST_HEAD(&priv->workers);



	priv->udev = usb_get_dev(interface_to_usbdev(interface));

	err = devm_add_action_or_reset(dev, gpio_mpsse_usb_put_dev, priv);

	if (err)

		return err;



	priv->udev = interface_to_usbdev(interface);

	priv->intf = interface;

	priv->intf_id = interface->cur_altsetting->desc.bInterfaceNumber;