Commit 367b3560 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

binder: remove redundant variable page_addr 



Variable page_addr is being assigned a value that is never read. The
variable is redundant and can be removed.

Cleans up clang scan build warning:
warning: Value stored to 'page_addr' is never read [deadcode.DeadStores]

Signed-off-by: default avatarColin Ian King <colin.i.king@intel.com>
Fixes: 162c7973 ("binder: avoid user addresses in debug logs")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312060851.cudv98wG-lkp@intel.com/


Acked-by: default avatarCarlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20240307221505.101431-1-cmllamas@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01994780

drivers/android/binder_alloc.c

+0 −2
Original line number Diff line number Diff line
@@ -925,7 +925,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc) 
		int i;



		for (i = 0; i < alloc->buffer_size / PAGE_SIZE; i++) {

			unsigned long page_addr;

			bool on_lru;



			if (!alloc->pages[i].page_ptr)
@@ -933,7 +932,6 @@ void binder_alloc_deferred_release(struct binder_alloc *alloc) 


			on_lru = list_lru_del_obj(&binder_freelist,

						  &alloc->pages[i].lru);

			page_addr = alloc->buffer + i * PAGE_SIZE;

			binder_alloc_debug(BINDER_DEBUG_BUFFER_ALLOC,

				     "%s: %d: page %d %s\n",

				     __func__, alloc->pid, i,