Commit 3693bb44 authored by Kunwu Chan's avatar Kunwu Chan Committed by Juergen Gross
Browse files

x86/xen: Add some null pointer checking to smp.c 



kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: default avatarKunwu Chan <chentao@kylinos.cn>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401161119.iof6BQsf-lkp@intel.com/


Suggested-by: default avatarMarkus Elfring <Markus.Elfring@web.de>
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20240119094948.275390-1-chentao@kylinos.cn


Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent 7d8c67dd

arch/x86/xen/smp.c

+12 −0
Original line number Diff line number Diff line
@@ -65,6 +65,8 @@ int xen_smp_intr_init(unsigned int cpu) 
	char *resched_name, *callfunc_name, *debug_name;



	resched_name = kasprintf(GFP_KERNEL, "resched%d", cpu);

	if (!resched_name)

		goto fail_mem;

	per_cpu(xen_resched_irq, cpu).name = resched_name;

	rc = bind_ipi_to_irqhandler(XEN_RESCHEDULE_VECTOR,

				    cpu,
@@ -77,6 +79,8 @@ int xen_smp_intr_init(unsigned int cpu) 
	per_cpu(xen_resched_irq, cpu).irq = rc;



	callfunc_name = kasprintf(GFP_KERNEL, "callfunc%d", cpu);

	if (!callfunc_name)

		goto fail_mem;

	per_cpu(xen_callfunc_irq, cpu).name = callfunc_name;

	rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_VECTOR,

				    cpu,
@@ -90,6 +94,9 @@ int xen_smp_intr_init(unsigned int cpu) 


	if (!xen_fifo_events) {

		debug_name = kasprintf(GFP_KERNEL, "debug%d", cpu);

		if (!debug_name)

			goto fail_mem;



		per_cpu(xen_debug_irq, cpu).name = debug_name;

		rc = bind_virq_to_irqhandler(VIRQ_DEBUG, cpu,

					     xen_debug_interrupt,
@@ -101,6 +108,9 @@ int xen_smp_intr_init(unsigned int cpu) 
	}



	callfunc_name = kasprintf(GFP_KERNEL, "callfuncsingle%d", cpu);

	if (!callfunc_name)

		goto fail_mem;



	per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name;

	rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_SINGLE_VECTOR,

				    cpu,
@@ -114,6 +124,8 @@ int xen_smp_intr_init(unsigned int cpu) 


	return 0;



 fail_mem:

	rc = -ENOMEM;

 fail:

	xen_smp_intr_free(cpu);

	return rc;