Commit 36e5da13 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Chun-Kuang Hu
Browse files

drm/mediatek: aal: Use bitfield macros 



Make the code more robust and improve readability by using bitfield
macros instead of open coding bit operations.

Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Reviewed-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20231012095736.100784-8-angelogioacchino.delregno@collabora.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 6e46998c

drivers/gpu/drm/mediatek/mtk_disp_aal.c

+8 −2
Original line number Diff line number Diff line
@@ -18,6 +18,8 @@ 
#define DISP_AAL_EN				0x0000

#define AAL_EN						BIT(0)

#define DISP_AAL_SIZE				0x0030

#define DISP_AAL_SIZE_HSIZE				GENMASK(28, 16)

#define DISP_AAL_SIZE_VSIZE				GENMASK(12, 0)

#define DISP_AAL_OUTPUT_SIZE			0x04d8

#define DISP_AAL_LUT_SIZE			512
@@ -51,9 +53,13 @@ void mtk_aal_config(struct device *dev, unsigned int w, 
			   unsigned int bpc, struct cmdq_pkt *cmdq_pkt)

{

	struct mtk_disp_aal *aal = dev_get_drvdata(dev);

	u32 sz;



	mtk_ddp_write(cmdq_pkt, w << 16 | h, &aal->cmdq_reg, aal->regs, DISP_AAL_SIZE);

	mtk_ddp_write(cmdq_pkt, w << 16 | h, &aal->cmdq_reg, aal->regs, DISP_AAL_OUTPUT_SIZE);

	sz = FIELD_PREP(DISP_AAL_SIZE_HSIZE, w);

	sz |= FIELD_PREP(DISP_AAL_SIZE_VSIZE, h);



	mtk_ddp_write(cmdq_pkt, sz, &aal->cmdq_reg, aal->regs, DISP_AAL_SIZE);

	mtk_ddp_write(cmdq_pkt, sz, &aal->cmdq_reg, aal->regs, DISP_AAL_OUTPUT_SIZE);

}



/**