Commit 36f10a91 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Damien Le Moal
Browse files

ata: pata_falcon: Stop using module_platform_driver_probe() 



On today's platforms the benefit of platform_driver_probe() isn't that
relevant any more. It allows to drop some code after booting (or module
loading) for .probe() and discard the .remove() function completely if
the driver is built-in. This typically saves a few 100k.

The downside of platform_driver_probe() is that the driver cannot be
bound and unbound at runtime which is ancient and so slightly
complicates testing. There are also thoughts to deprecate
platform_driver_probe() because it adds some complexity in the driver
core for little gain. Also many drivers don't use it correctly. This
driver for example misses to mark the driver struct with __ref which is
needed to suppress a (W=1) modpost warning.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent fd3a6837

drivers/ata/pata_falcon.c

+5 −4
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static struct ata_port_operations pata_falcon_ops = { 
	.set_mode	= pata_falcon_set_mode,

};



static int __init pata_falcon_init_one(struct platform_device *pdev)

static int pata_falcon_init_one(struct platform_device *pdev)

{

	struct resource *base_mem_res, *ctl_mem_res;

	struct resource *base_res, *ctl_res, *irq_res;
@@ -216,7 +216,7 @@ static int __init pata_falcon_init_one(struct platform_device *pdev) 
				 IRQF_SHARED, &pata_falcon_sht);

}



static int __exit pata_falcon_remove_one(struct platform_device *pdev)

static int pata_falcon_remove_one(struct platform_device *pdev)

{

	struct ata_host *host = platform_get_drvdata(pdev);
@@ -226,13 +226,14 @@ static int __exit pata_falcon_remove_one(struct platform_device *pdev) 
}



static struct platform_driver pata_falcon_driver = {

	.remove = __exit_p(pata_falcon_remove_one),

	.probe = pata_falcon_init_one,

	.remove = pata_falcon_remove_one,

	.driver   = {

		.name	= "atari-falcon-ide",

	},

};



module_platform_driver_probe(pata_falcon_driver, pata_falcon_init_one);

module_platform_driver(pata_falcon_driver);



MODULE_AUTHOR("Bartlomiej Zolnierkiewicz");

MODULE_DESCRIPTION("low-level driver for Atari Falcon PATA");