Commit 3727ca56 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcachefs: Fix a locking bug in the do_discard_fast() path 



We can't discard a bucket while it's still open; this needs the
bucket_is_open_safe() version, which takes the open_buckets lock.

Signed-off-by: default avatarKent Overstreet <kent.overstreet@linux.dev>
parent d47df4f6

fs/bcachefs/alloc_background.c

+1 −1
Original line number Diff line number Diff line
@@ -882,7 +882,7 @@ int bch2_trigger_alloc(struct btree_trans *trans, 
			closure_wake_up(&c->freelist_wait);



		if (statechange(a->data_type == BCH_DATA_need_discard) &&

		    !bch2_bucket_is_open(c, new.k->p.inode, new.k->p.offset) &&

		    !bch2_bucket_is_open_safe(c, new.k->p.inode, new.k->p.offset) &&

		    bucket_flushed(new_a))

			bch2_discard_one_bucket_fast(c, new.k->p);