Commit 3767426b authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: wm831x: don't print out global GPIO numbers in debugfs callbacks 



In order to further limit the number of references to the GPIO base
number stored in struct gpio_chip, replace the global GPIO numbers in
the output of debugfs callbacks by hardware offsets.

Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250826-gpio-dbg-show-base-v1-3-7f27cd7f2256@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent ddeb66d2

drivers/gpio/gpio-wm831x.c

+2 −3
Original line number Diff line number Diff line
@@ -159,7 +159,6 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) 
	int i, tristated;



	for (i = 0; i < chip->ngpio; i++) {

		int gpio = i + chip->base;

		int reg;

		const char *pull, *powerdomain;
@@ -175,13 +174,13 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) 
		}



		seq_printf(s, " gpio-%-3d (%-20.20s) ",

			   gpio, label ?: "Unrequested");

			   i, label ?: "Unrequested");



		reg = wm831x_reg_read(wm831x, WM831X_GPIO1_CONTROL + i);

		if (reg < 0) {

			dev_err(wm831x->dev,

				"GPIO control %d read failed: %d\n",

				gpio, reg);

				i, reg);

			seq_putc(s, '\n');

			continue;

		}