Commit 37848a45 authored Jul 15, 2025 by Matthieu Baerts (NGI0) Committed by Jakub Kicinski Jul 21, 2025

selftests: mptcp: connect: also cover alt modes



The "mmap" and "sendfile" alternate modes for mptcp_connect.sh/.c are
available from the beginning, but only tested when mptcp_connect.sh is
manually launched with "-m mmap" or "-m sendfile", not via the
kselftests helpers.

The MPTCP CI was manually running "mptcp_connect.sh -m mmap", but not
"-m sendfile". Plus other CIs, especially the ones validating the stable
releases, were not validating these alternate modes.

To make sure these modes are validated by these CIs, add two new test
programs executing mptcp_connect.sh with the alternate modes.

Fixes: 048d19d4 ("mptcp: add basic kselftest for mptcp")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250715-net-mptcp-sft-connect-alt-v2-1-8230ddd82454@kernel.org


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 81e0db8e

tools/testing/selftests/net/mptcp/Makefile

+2 −1

Original line number	Diff line number	Diff line
		@@ -4,7 +4,8 @@ top_srcdir = ../../../../..

		CFLAGS += -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES)

		TEST_PROGS := mptcp_connect.sh pm_netlink.sh mptcp_join.sh diag.sh \
		TEST_PROGS := mptcp_connect.sh mptcp_connect_mmap.sh mptcp_connect_sendfile.sh \
		pm_netlink.sh mptcp_join.sh diag.sh \
		simult_flows.sh mptcp_sockopt.sh userspace_pm.sh

		TEST_GEN_FILES = mptcp_connect pm_nl_ctl mptcp_sockopt mptcp_inq mptcp_diag

tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh

0 → 100755

+5 −0

Original line number	Diff line number	Diff line
		#!/bin/bash
		# SPDX-License-Identifier: GPL-2.0

		MPTCP_LIB_KSFT_TEST="$(basename "${0}" .sh)" \
		"$(dirname "${0}")/mptcp_connect.sh" -m mmap "${@}"

tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh

0 → 100755

+5 −0

Original line number	Diff line number	Diff line
		#!/bin/bash
		# SPDX-License-Identifier: GPL-2.0

		MPTCP_LIB_KSFT_TEST="$(basename "${0}" .sh)" \
		"$(dirname "${0}")/mptcp_connect.sh" -m sendfile "${@}"