Commit 3787fb76 authored by Thorsten Blum's avatar Thorsten Blum Committed by Herbert Xu
Browse files

crypto: qce - simplify qce_xts_swapiv() 



Declare 'swap' as zero-initialized and use a single index variable to
simplify the byte-swapping loop in qce_xts_swapiv(). Add a comment for
clarity.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 1ee57ab9

drivers/crypto/qce/common.c

+6 −6
Original line number Diff line number Diff line
@@ -280,17 +280,17 @@ static u32 qce_encr_cfg(unsigned long flags, u32 aes_key_size) 
#ifdef CONFIG_CRYPTO_DEV_QCE_SKCIPHER

static void qce_xts_swapiv(__be32 *dst, const u8 *src, unsigned int ivsize)

{

	u8 swap[QCE_AES_IV_LENGTH];

	u32 i, j;

	u8 swap[QCE_AES_IV_LENGTH] = {0};

	unsigned int i, offset;



	if (ivsize > QCE_AES_IV_LENGTH)

		return;



	memset(swap, 0, QCE_AES_IV_LENGTH);

	offset = QCE_AES_IV_LENGTH - ivsize;



	for (i = (QCE_AES_IV_LENGTH - ivsize), j = ivsize - 1;

	     i < QCE_AES_IV_LENGTH; i++, j--)

		swap[i] = src[j];

	/* Reverse and right-align IV bytes. */

	for (i = 0; i < ivsize; i++)

		swap[offset + i] = src[ivsize - 1 - i];



	qce_cpu_to_be32p_array(dst, swap, QCE_AES_IV_LENGTH);

}