Commit 37a9acb9 authored by Chelsy Ratnawat's avatar Chelsy Ratnawat Committed by Jiri Kosina
Browse files

HID: replace scnprintf() with sysfs_emit() 



Documentation/filesystems/sysfs.rst mentions that show() should only
use sysfs_emit() or sysfs_emit_at() when formating the value to be
returned to user space. So replace scnprintf() with sysfs_emit().

Signed-off-by: default avatarChelsy Ratnawat <chelsyratnawat2001@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent d3db1ce9

drivers/hid/hid-core.c

+1 −1
Original line number Diff line number Diff line
@@ -2797,7 +2797,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *a, 
{

	struct hid_device *hdev = container_of(dev, struct hid_device, dev);



	return scnprintf(buf, PAGE_SIZE, "hid:b%04Xg%04Xv%08Xp%08X\n",

	return sysfs_emit(buf, "hid:b%04Xg%04Xv%08Xp%08X\n",

			 hdev->bus, hdev->group, hdev->vendor, hdev->product);

}

static DEVICE_ATTR_RO(modalias);

drivers/hid/hid-lg4ff.c

+3 −3
Original line number Diff line number Diff line
@@ -956,7 +956,7 @@ static ssize_t lg4ff_combine_show(struct device *dev, struct device_attribute *a 
		return 0;

	}



	count = scnprintf(buf, PAGE_SIZE, "%u\n", entry->wdata.combine);

	count = sysfs_emit(buf, "%u\n", entry->wdata.combine);

	return count;

}
@@ -1009,7 +1009,7 @@ static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *att 
		return 0;

	}



	count = scnprintf(buf, PAGE_SIZE, "%u\n", entry->wdata.range);

	count = sysfs_emit(buf, "%u\n", entry->wdata.range);

	return count;

}
@@ -1073,7 +1073,7 @@ static ssize_t lg4ff_real_id_show(struct device *dev, struct device_attribute *a 
		return 0;

	}



	count = scnprintf(buf, PAGE_SIZE, "%s: %s\n", entry->wdata.real_tag, entry->wdata.real_name);

	count = sysfs_emit(buf, "%s: %s\n", entry->wdata.real_tag, entry->wdata.real_name);

	return count;

}