Unverified Commit 37d11cfc authored by Mateusz Guzik's avatar Mateusz Guzik Committed by Christian Brauner
Browse files

vfs: sanity check the length passed to inode_set_cached_link() 



This costs a strlen() call when instatianating a symlink.

Preferably it would be hidden behind VFS_WARN_ON (or compatible), but
there is no such facility at the moment. With the facility in place the
call can be patched out in production kernels.

In the meantime, since the cost is being paid unconditionally, use the
result to a fixup the bad caller.

This is not expected to persist in the long run (tm).

Sample splat:
bad length passed for symlink [/tmp/syz-imagegen43743633/file0/file0] (got 131109, expected 37)
[rest of WARN blurp goes here]

Signed-off-by: default avatarMateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20250204213207.337980-1-mjguzik@gmail.com


Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 091ee63e

include/linux/fs.h

+13 −0
Original line number Diff line number Diff line
@@ -790,6 +790,19 @@ struct inode { 


static inline void inode_set_cached_link(struct inode *inode, char *link, int linklen)

{

	int testlen;



	/*

	 * TODO: patch it into a debug-only check if relevant macros show up.

	 * In the meantime, since we are suffering strlen even on production kernels

	 * to find the right length, do a fixup if the wrong value got passed.

	 */

	testlen = strlen(link);

	if (testlen != linklen) {

		WARN_ONCE(1, "bad length passed for symlink [%s] (got %d, expected %d)",

			  link, linklen, testlen);

		linklen = testlen;

	}

	inode->i_link = link;

	inode->i_linklen = linklen;

	inode->i_opflags |= IOP_CACHED_LINK;