Commit 37d40a21 authored by Aurelien Jarno's avatar Aurelien Jarno Committed by Vinod Koul
Browse files

phy: rockchip-snps-pcie3: only look for rockchip,pipe-grf on rk3588 



The rockchip,pipe-grf property is only used on rk3588, but not on
rk3568. Therefore this property is not present on rk3568 devices,
leading to the following message:

  rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap

Fix that by only looking for this property on rk3588.

Fixes: 2e9bffc4 ("phy: rockchip: Support PCIe v3")
Signed-off-by: default avatarAurelien Jarno <aurelien@aurel32.net>
Link: https://lore.kernel.org/r/20220927051752.53089-1-aurelien@aurel32.net


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 03b756d2

drivers/phy/rockchip/phy-rockchip-snps-pcie3.c

+9 −4
Original line number Diff line number Diff line
@@ -255,10 +255,15 @@ static int rockchip_p3phy_probe(struct platform_device *pdev) 
		return PTR_ERR(priv->phy_grf);

	}



	priv->pipe_grf = syscon_regmap_lookup_by_phandle(dev->of_node,

	if (of_device_is_compatible(np, "rockchip,rk3588-pcie3-phy")) {

		priv->pipe_grf =

			syscon_regmap_lookup_by_phandle(dev->of_node,

							"rockchip,pipe-grf");

		if (IS_ERR(priv->pipe_grf))

			dev_info(dev, "failed to find rockchip,pipe_grf regmap\n");

	} else {

		priv->pipe_grf = NULL;

	}



	priv->num_lanes = of_property_read_variable_u32_array(dev->of_node, "data-lanes",

							     priv->lanes, 2,