Commit 37d4159d authored by Jan Kara's avatar Jan Kara Committed by Anna Schumaker
Browse files

nfs: Drop pointless check from nfs_commit_release_pages() 



nfss->writeback is updated only when we are ending page writeback and at
that moment we also clear nfss->write_congested. So there's no point in
rechecking congestion state in nfs_commit_release_pages(). Drop the
pointless check.

Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 7d09d6bb

fs/nfs/write.c

+0 −4
Original line number Diff line number Diff line
@@ -1846,7 +1846,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data) 
	struct nfs_page	*req;

	int status = data->task.tk_status;

	struct nfs_commit_info cinfo;

	struct nfs_server *nfss;

	struct folio *folio;



	while (!list_empty(&data->pages)) {
@@ -1889,9 +1888,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data) 
		/* Latency breaker */

		cond_resched();

	}

	nfss = NFS_SERVER(data->inode);

	if (atomic_long_read(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)

		nfss->write_congested = 0;



	nfs_init_cinfo(&cinfo, data->inode, data->dreq);

	nfs_commit_end(cinfo.mds);