Commit 37d66cf0 authored by Wentao Guan's avatar Wentao Guan Committed by Jiri Kosina
Browse files

HID: intel-thc-hid: intel-quicki2c: pass correct arguments to acpi_evaluate_object 



Delete unused argument, pass correct argument to acpi_evaluate_object.

Log:
  intel_quicki2c 0000:00:10.0: enabling device (0000 -> 0002)
  ACPI: \_SB.PC00.THC0.ICRS: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)
  ACPI: \_SB.PC00.THC0.ISUB: 1 arguments were passed to a non-method ACPI object (Buffer) (20230628/nsarguments-211)

Fixes: 5282e45c ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C ACPI interfaces")
Signed-off-by: default avatarWentao Guan <guanwentao@uniontech.com>
Signed-off-by: default avatarWangYuli <wangyuli@uniontech.com>
Reviewed-by: default avatarEven Xu <even.xu@intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 5e06802b

drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c

+1 −6
Original line number Diff line number Diff line
@@ -82,15 +82,10 @@ static int quicki2c_acpi_get_dsd_property(struct acpi_device *adev, acpi_string 
{

	acpi_handle handle = acpi_device_handle(adev);

	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };

	union acpi_object obj = { .type = type };

	struct acpi_object_list arg_list = {

		.count = 1,

		.pointer = &obj,

	};

	union acpi_object *ret_obj;

	acpi_status status;



	status = acpi_evaluate_object(handle, dsd_method_name, &arg_list, &buffer);

	status = acpi_evaluate_object(handle, dsd_method_name, NULL, &buffer);

	if (ACPI_FAILURE(status)) {

		acpi_handle_err(handle,

				"Can't evaluate %s method: %d\n", dsd_method_name, status);