Commit 383baf5c authored by Mrinmay Sarkar's avatar Mrinmay Sarkar Committed by Vinod Koul
Browse files

dmaengine: dw-edma: Fix unmasking STOP and ABORT interrupts for HDMA 



The current logic is enabling both STOP_INT_MASK and ABORT_INT_MASK
bit. This is apparently masking those particular interrupts rather than
unmasking the same. If the interrupts are masked, they would never get
triggered.

So fix the issue by unmasking the STOP and ABORT interrupts properly.

Fixes: e74c3957 ("dmaengine: dw-edma: Add support for native HDMA")
cc: stable@vger.kernel.org
Signed-off-by: default avatarMrinmay Sarkar <quic_msarkar@quicinc.com>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/1724674261-3144-2-git-send-email-quic_msarkar@quicinc.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b53b8319

drivers/dma/dw-edma/dw-hdma-v0-core.c

+5 −4
Original line number Diff line number Diff line
@@ -247,10 +247,11 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) 
	if (first) {

		/* Enable engine */

		SET_CH_32(dw, chan->dir, chan->id, ch_en, BIT(0));

		/* Interrupt enable&unmask - done, abort */

		tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) |

		      HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK |

		      HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;

		/* Interrupt unmask - stop, abort */

		tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup);

		tmp &= ~(HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK);

		/* Interrupt enable - stop, abort */

		tmp |= HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN;

		if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL))

			tmp |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN;

		SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp);