Commit 384150d7 authored by Haotian Zhang's avatar Haotian Zhang Committed by Alexandre Belloni
Browse files

rtc: amlogic-a4: fix double free caused by devm 



The clock obtained via devm_clk_get_enabled() is automatically managed
by devres and will be disabled and freed on driver detach. Manually
calling clk_disable_unprepare() in error path and remove function
causes double free.

Remove the redundant clk_disable_unprepare() calls from the probe
error path and aml_rtc_remove(), allowing the devm framework to
automatically manage the clock lifecycle.

Fixes: c89ac918 ("rtc: support for the Amlogic on-chip RTC")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: default avatarXianwei Zhao <xianwei.zhao@amlogic.com>
Link: https://patch.msgid.link/20251021103559.1903-1-vulab@iscas.ac.cn


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 3a866087

drivers/rtc/rtc-amlogic-a4.c

+0 −4
Original line number Diff line number Diff line
@@ -390,7 +390,6 @@ static int aml_rtc_probe(struct platform_device *pdev) 


	return 0;

err_clk:

	clk_disable_unprepare(rtc->sys_clk);

	device_init_wakeup(dev, false);



	return ret;
@@ -423,9 +422,6 @@ static SIMPLE_DEV_PM_OPS(aml_rtc_pm_ops, 


static void aml_rtc_remove(struct platform_device *pdev)

{

	struct aml_rtc_data *rtc = dev_get_drvdata(&pdev->dev);



	clk_disable_unprepare(rtc->sys_clk);

	device_init_wakeup(&pdev->dev, false);

}