Unverified Commit 38492c57 authored by Dmitry Safonov's avatar Dmitry Safonov Committed by Nathan Chancellor
Browse files

gen_init_cpio: Ignore fsync() returning EINVAL on pipes 



The reproducer:
echo | ./usr/gen_init_cpio /dev/stdin > /dev/null

fsync() on a pipe fd returns -EINVAL, which makes gen_init_cpio fail.
Ignore -EINVAL from fsync().

Fixes: ae18b940 ("gen_init_cpio: support -o <output_file> parameter")
Cc: David Disseldorp <ddiss@suse.de>
Cc: Nicolas Schier <nsc@kernel.org>
Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Reviewed-by: default avatarDavid Disseldorp <ddiss@suse.de>
Link: https://patch.msgid.link/20251007-gen_init_cpio-pipe-v2-1-b098ab94b58a@arista.com


Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
parent 7ded7d37

usr/gen_init_cpio.c

+4 −1
Original line number Diff line number Diff line
@@ -112,7 +112,10 @@ static int cpio_trailer(void) 
	    push_pad(padlen(offset, 512)) < 0)

		return -1;



	return fsync(outfd);

	if (fsync(outfd) < 0 && errno != EINVAL)

		return -1;



	return 0;

}



static int cpio_mkslink(const char *name, const char *target,