Commit 384bd58b authored by Haotian Zhang's avatar Haotian Zhang Committed by Lee Jones
Browse files

mfd: mt6358-irq: Fix missing irq_domain_remove() in error path 



If devm_request_threaded_irq() fails after irq_domain_add_linear()
succeeds in mt6358_irq_init(), the function returns without removing
the created IRQ domain, leading to a resource leak.

Call irq_domain_remove() in the error path after a successful
irq_domain_add_linear() to properly release the IRQ domain.

Fixes: 2b91c28f ("mfd: Add support for the MediaTek MT6358 PMIC")
Signed-off-by: default avatarHaotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251118121427.583-1-vulab@iscas.ac.cn


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent b4b1bd1f

drivers/mfd/mt6358-irq.c

+1 −0
Original line number Diff line number Diff line
@@ -285,6 +285,7 @@ int mt6358_irq_init(struct mt6397_chip *chip) 
	if (ret) {

		dev_err(chip->dev, "Failed to register IRQ=%d, ret=%d\n",

			chip->irq, ret);

		irq_domain_remove(chip->irq_domain);

		return ret;

	}