Commit 384fa864 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Greg Kroah-Hartman
Browse files

serial: 8250: Remove superfluous sanity check 



The serial core already checks the RS485 RTS settings for sanity, so remove
the superfluous check in serial8250_em485_config().

Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Link: https://lore.kernel.org/r/20240407002709.16224-4-l.sanfilippo@kunbus.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 255abd49

drivers/tty/serial/8250/8250_port.c

+0 −7
Original line number Diff line number Diff line
@@ -612,13 +612,6 @@ int serial8250_em485_config(struct uart_port *port, struct ktermios *termios, 
{

	struct uart_8250_port *up = up_to_u8250p(port);



	/* pick sane settings if the user hasn't */

	if (!!(rs485->flags & SER_RS485_RTS_ON_SEND) ==

	    !!(rs485->flags & SER_RS485_RTS_AFTER_SEND)) {

		rs485->flags |= SER_RS485_RTS_ON_SEND;

		rs485->flags &= ~SER_RS485_RTS_AFTER_SEND;

	}



	/*

	 * Both serial8250_em485_init() and serial8250_em485_destroy()

	 * are idempotent.