Commit 38516e3f authored by Aswin Karuvally's avatar Aswin Karuvally Committed by Jakub Kicinski
Browse files

s390/iucv: Convert sprintf/snprintf to scnprintf 

Convert sprintf/snprintf calls to scnprintf to better align with the
kernel development community practices [1].

Link: https://lwn.net/Articles/69419

 [1]
Reviewed-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Signed-off-by: default avatarAswin Karuvally <aswin@linux.ibm.com>
Signed-off-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251017094954.1402684-1-wintera@linux.ibm.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent baa515ef

drivers/s390/net/smsgiucv_app.c

+4 −3
Original line number Diff line number Diff line
@@ -88,9 +88,10 @@ static struct smsg_app_event *smsg_app_event_alloc(const char *from, 
	ev->envp[3] = NULL;



	/* setting up environment: sender, prefix name, and message text */

	snprintf(ev->envp[0], ENV_SENDER_LEN, ENV_SENDER_STR "%s", from);

	snprintf(ev->envp[1], ENV_PREFIX_LEN, ENV_PREFIX_STR "%s", SMSG_PREFIX);

	snprintf(ev->envp[2], ENV_TEXT_LEN(msg), ENV_TEXT_STR "%s", msg);

	scnprintf(ev->envp[0], ENV_SENDER_LEN, ENV_SENDER_STR "%s", from);

	scnprintf(ev->envp[1], ENV_PREFIX_LEN, ENV_PREFIX_STR "%s",

		  SMSG_PREFIX);

	scnprintf(ev->envp[2], ENV_TEXT_LEN(msg), ENV_TEXT_STR "%s", msg);



	return ev;

}

net/iucv/af_iucv.c

+4 −3
Original line number Diff line number Diff line
@@ -553,9 +553,10 @@ static void __iucv_auto_name(struct iucv_sock *iucv) 
{

	char name[12];



	sprintf(name, "%08x", atomic_inc_return(&iucv_sk_list.autobind_name));

	scnprintf(name, sizeof(name),

		  "%08x", atomic_inc_return(&iucv_sk_list.autobind_name));

	while (__iucv_get_sock_by_name(name)) {

		sprintf(name, "%08x",

		scnprintf(name, sizeof(name), "%08x",

			  atomic_inc_return(&iucv_sk_list.autobind_name));

	}

	memcpy(iucv->src_name, name, 8);

net/iucv/iucv.c

+1 −1
Original line number Diff line number Diff line
@@ -95,7 +95,7 @@ struct device *iucv_alloc_device(const struct attribute_group **attrs, 
	if (!dev)

		goto out_error;

	va_start(vargs, fmt);

	vsnprintf(buf, sizeof(buf), fmt, vargs);

	vscnprintf(buf, sizeof(buf), fmt, vargs);

	rc = dev_set_name(dev, "%s", buf);

	va_end(vargs);

	if (rc)