Commit 38940514 authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Sebastian Reichel
Browse files

power: supply: Remove redundant dev_err_probe() for platform_get_irq_byname() 



There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq_byname()
function as it is going to display an appropriate error message
in case of a failure.

Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarDhruva Gole <d-gole@ti.com>
Link: https://lore.kernel.org/r/20230727113550.2599335-1-ruanjinjie@huawei.com


Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 6eca10a1

drivers/power/supply/mt6370-charger.c

+1 −3
Original line number Diff line number Diff line
@@ -849,9 +849,7 @@ static int mt6370_chg_init_irq(struct mt6370_priv *priv) 
		ret = platform_get_irq_byname(to_platform_device(priv->dev),

					      mt6370_chg_irqs[i].name);

		if (ret < 0)

			return dev_err_probe(priv->dev, ret,

					     "Failed to get irq %s\n",

					     mt6370_chg_irqs[i].name);

			return ret;



		priv->irq_nums[i] = ret;

		ret = devm_request_threaded_irq(priv->dev, ret, NULL,

drivers/power/supply/qcom_pmi8998_charger.c

+1 −2
Original line number Diff line number Diff line
@@ -915,8 +915,7 @@ static int smb2_init_irq(struct smb2_chip *chip, int *irq, const char *name, 


	irqnum = platform_get_irq_byname(to_platform_device(chip->dev), name);

	if (irqnum < 0)

		return dev_err_probe(chip->dev, irqnum,

				     "Couldn't get irq %s byname\n", name);

		return irqnum;



	rc = devm_request_threaded_irq(chip->dev, irqnum, NULL, handler,

				       IRQF_ONESHOT, name, chip);