Commit 38a285d5 authored by Tzuyi Chang's avatar Tzuyi Chang Committed by Linus Walleij
Browse files

pinctrl: realtek: Fix logical error when finding descriptor 



The pin descriptor should be returned if the name has been found in the
descriptor table. Remove the negation in the if statement for accurate
retrieval.

Fixes: e99ce780 ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
Signed-off-by: default avatarTzuyi Chang <tychang@realtek.com>
Link: https://lore.kernel.org/r/20231121091107.5564-1-tychang@realtek.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 65887324

drivers/pinctrl/realtek/pinctrl-rtd.c

+2 −2
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static int rtd_pinctrl_get_function_groups(struct pinctrl_dev *pcdev, 


static const struct rtd_pin_desc *rtd_pinctrl_find_mux(struct rtd_pinctrl *data, unsigned int pin)

{

	if (!data->info->muxes[pin].name)

	if (data->info->muxes[pin].name)

		return &data->info->muxes[pin];



	return NULL;
@@ -249,7 +249,7 @@ static const struct pinctrl_pin_desc 
static const struct rtd_pin_config_desc

	*rtd_pinctrl_find_config(struct rtd_pinctrl *data, unsigned int pin)

{

	if (!data->info->configs[pin].name)

	if (data->info->configs[pin].name)

		return &data->info->configs[pin];



	return NULL;