Unverified Commit 38d1227f authored by Xichao Zhao's avatar Xichao Zhao Committed by Christian Brauner
Browse files

fs: Replace offsetof() with struct_size() in ioctl_file_dedupe_range() 



When dealing with structures containing flexible arrays, struct_size()
provides additional compile-time checks compared to offsetof(). This
enhances code robustness and reduces the risk of potential errors.

Signed-off-by: default avatarXichao Zhao <zhao.xichao@vivo.com>
Link: https://lore.kernel.org/20250829091510.597858-1-zhao.xichao@vivo.com


Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent ec6f613e

fs/ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -426,7 +426,7 @@ static int ioctl_file_dedupe_range(struct file *file, 
		goto out;

	}



	size = offsetof(struct file_dedupe_range, info[count]);

	size = struct_size(same, info, count);

	if (size > PAGE_SIZE) {

		ret = -ENOMEM;

		goto out;