Commit 391b41f9 authored by Fabrizio Castro's avatar Fabrizio Castro Committed by Bartosz Golaszewski
Browse files

gpio: rcar: Fix missing of_node_put() call 



of_parse_phandle_with_fixed_args() requires its caller to
call into of_node_put() on the node pointer from the output
structure, but such a call is currently missing.

Call into of_node_put() to rectify that.

Fixes: 159f8a02 ("gpio-rcar: Add DT support")
Signed-off-by: default avatarFabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20250305163753.34913-2-fabrizio.castro.jz@renesas.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent f02c41f8

drivers/gpio/gpio-rcar.c

+6 −1
Original line number Diff line number Diff line
@@ -468,7 +468,12 @@ static int gpio_rcar_parse_dt(struct gpio_rcar_priv *p, unsigned int *npins) 
	p->info = *info;



	ret = of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3, 0, &args);

	*npins = ret == 0 ? args.args[2] : RCAR_MAX_GPIO_PER_BANK;

	if (ret) {

		*npins = RCAR_MAX_GPIO_PER_BANK;

	} else {

		*npins = args.args[2];

		of_node_put(args.np);

	}



	if (*npins == 0 || *npins > RCAR_MAX_GPIO_PER_BANK) {

		dev_warn(p->dev, "Invalid number of gpio lines %u, using %u\n",