Unverified Commit 39237e32 authored by Marco Nenciarini's avatar Marco Nenciarini Committed by Ilpo Järvinen
Browse files

platform/x86: int3472: Rename pled to led in LED registration code 



Rename the privacy LED type, struct member, and functions from "pled"
to "led" in preparation for supporting additional LED types beyond
just the privacy LED.

No functional change.

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarHans de Goede <johannes.goede@oss.qualcomm.com>
Signed-off-by: default avatarMarco Nenciarini <mnencia@kcore.it>
Link: https://patch.msgid.link/20260401203638.1601661-3-mnencia@kcore.it


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent d6116d86

drivers/platform/x86/intel/int3472/discrete.c

+2 −2
Original line number Diff line number Diff line
@@ -354,7 +354,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, 


			break;

		case INT3472_GPIO_TYPE_PRIVACY_LED:

			ret = skl_int3472_register_pled(int3472, gpio);

			ret = skl_int3472_register_led(int3472, gpio);

			if (ret)

				err_msg = "Failed to register LED\n";
@@ -429,7 +429,7 @@ void int3472_discrete_cleanup(struct int3472_discrete_device *int3472) 
	gpiod_remove_lookup_table(&int3472->gpios);



	skl_int3472_unregister_clock(int3472);

	skl_int3472_unregister_pled(int3472);

	skl_int3472_unregister_led(int3472);

	skl_int3472_unregister_regulator(int3472);

}

EXPORT_SYMBOL_NS_GPL(int3472_discrete_cleanup, "INTEL_INT3472_DISCRETE");

drivers/platform/x86/intel/int3472/led.c

+7 −7
Original line number Diff line number Diff line
@@ -6,17 +6,17 @@ 
#include <linux/leds.h>

#include <linux/platform_data/x86/int3472.h>



static int int3472_pled_set(struct led_classdev *led_cdev, enum led_brightness brightness)

static int int3472_led_set(struct led_classdev *led_cdev, enum led_brightness brightness)

{

	struct int3472_pled *led = container_of(led_cdev, struct int3472_pled, classdev);

	struct int3472_led *led = container_of(led_cdev, struct int3472_led, classdev);



	gpiod_set_value_cansleep(led->gpio, brightness);

	return 0;

}



int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)

int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio)

{

	struct int3472_pled *led = &int3472->pled;

	struct int3472_led *led = &int3472->led;

	char *p;

	int ret;
@@ -34,7 +34,7 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp 


	led->classdev.name = led->name;

	led->classdev.max_brightness = 1;

	led->classdev.brightness_set_blocking = int3472_pled_set;

	led->classdev.brightness_set_blocking = int3472_led_set;



	ret = led_classdev_register(int3472->dev, &led->classdev);

	if (ret)
@@ -48,9 +48,9 @@ int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gp 
	return 0;

}



void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472)

void skl_int3472_unregister_led(struct int3472_discrete_device *int3472)

{

	struct int3472_pled *led = &int3472->pled;

	struct int3472_led *led = &int3472->led;



	if (IS_ERR_OR_NULL(led->classdev.dev))

		return;

include/linux/platform_data/x86/int3472.h

+4 −4
Original line number Diff line number Diff line
@@ -122,12 +122,12 @@ struct int3472_discrete_device { 
		u8 imgclk_index;

	} clock;



	struct int3472_pled {

	struct int3472_led {

		struct led_classdev classdev;

		struct led_lookup_data lookup;

		char name[INT3472_LED_MAX_NAME_LEN];

		struct gpio_desc *gpio;

	} pled;

	} led;



	struct int3472_discrete_quirks quirks;
@@ -161,7 +161,7 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472, 
				   const char *second_sensor);

void skl_int3472_unregister_regulator(struct int3472_discrete_device *int3472);



int skl_int3472_register_pled(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);

void skl_int3472_unregister_pled(struct int3472_discrete_device *int3472);

int skl_int3472_register_led(struct int3472_discrete_device *int3472, struct gpio_desc *gpio);

void skl_int3472_unregister_led(struct int3472_discrete_device *int3472);



#endif