Commit 39361c99 authored by Stephan Gerhold's avatar Stephan Gerhold Committed by Jonathan Cameron
Browse files

dt-bindings: iio: accel: bma255: Fix interrupt type 



Bosch accelerometers similar to BMA255 are initially configured to
emit an active-high interrupt signal. This is currently not re-configured
in the bmc150-accel driver so the interrupt should most certainly be
IRQ_TYPE_EDGE_RISING (or potentially IRQ_TYPE_LEVEL_HIGH).
(Unless there is some kind of inverter installed on the board...)

At the moment the bmc150-accel driver forcefully requests the IRQ
using IRQF_TRIGGER_RISING, which means that the IRQ type is currently
ignored in all existing device trees.

Fixes: 6259551c ("iio: accel: bmc150-accel: Add DT bindings")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarStephan Gerhold <stephan@gerhold.net>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210614163150.7774-2-stephan@gerhold.net


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent b44ab6fd

Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml

+2 −2
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ properties: 
    description: |

      The first interrupt listed must be the one connected to the INT1 pin,

      the second (optional) interrupt listed must be the one connected to the

      INT2 pin (if available).

      INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.



  mount-matrix:

    description: an optional 3x3 mounting rotation matrix.
@@ -63,7 +63,7 @@ examples: 
            reg = <0x08>;

            vddio-supply = <&vddio>;

            vdd-supply = <&vdd>;

            interrupts = <57 IRQ_TYPE_EDGE_FALLING>;

            interrupts = <57 IRQ_TYPE_EDGE_RISING>;

        };

    };

  - |