Commit 39646f29 authored by Johan Hovold's avatar Johan Hovold Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: add quirk for broken address properties 



Some Bluetooth controllers lack persistent storage for the device
address and instead one can be provided by the boot firmware using the
'local-bd-address' devicetree property.

The Bluetooth devicetree bindings clearly states that the address should
be specified in little-endian order, but due to a long-standing bug in
the Qualcomm driver which reversed the address some boot firmware has
been providing the address in big-endian order instead.

Add a new quirk that can be set on platforms with broken firmware and
use it to reverse the address when parsing the property so that the
underlying driver bug can be fixed.

Fixes: 5c0a1001 ("Bluetooth: hci_qca: Add helper to set device address")
Cc: stable@vger.kernel.org      # 5.1
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent e12e2800

include/net/bluetooth/hci.h

+9 −0
Original line number Diff line number Diff line
@@ -176,6 +176,15 @@ enum { 
	 */

	HCI_QUIRK_USE_BDADDR_PROPERTY,



	/* When this quirk is set, the Bluetooth Device Address provided by

	 * the 'local-bd-address' fwnode property is incorrectly specified in

	 * big-endian order.

	 *

	 * This quirk can be set before hci_register_dev is called or

	 * during the hdev->setup vendor callback.

	 */

	HCI_QUIRK_BDADDR_PROPERTY_BROKEN,



	/* When this quirk is set, the duplicate filtering during

	 * scanning is based on Bluetooth devices addresses. To allow

	 * RSSI based updates, restart scanning if needed.

net/bluetooth/hci_sync.c

+4 −1
Original line number Diff line number Diff line
@@ -3416,6 +3416,9 @@ static void hci_dev_get_bd_addr_from_property(struct hci_dev *hdev) 
	if (ret < 0 || !bacmp(&ba, BDADDR_ANY))

		return;



	if (test_bit(HCI_QUIRK_BDADDR_PROPERTY_BROKEN, &hdev->quirks))

		baswap(&hdev->public_addr, &ba);

	else

		bacpy(&hdev->public_addr, &ba);

}