Commit 399d1093 authored by Robert Marko's avatar Robert Marko Committed by Jakub Kicinski
Browse files

net: phy: micrel: always set shared->phydev for LAN8814 



Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP
clock gets actually set, otherwise the function will return before setting
it.

This is an issue as shared->phydev is unconditionally being used when IRQ
is being handled, especially in lan8814_gpio_process_cap and since it was
not set it will cause a NULL pointer exception and crash the kernel.

So, simply always set shared->phydev to avoid the NULL pointer exception.

Fixes: b3f1a08f ("net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814")
Signed-off-by: default avatarRobert Marko <robert.marko@sartura.hr>
Tested-by: default avatarHoratiu Vultur <horatiu.vultur@microchip.com>
Link: https://patch.msgid.link/20251021132034.983936-1-robert.marko@sartura.hr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f7c877e7

drivers/net/phy/micrel.c

+2 −2
Original line number Diff line number Diff line
@@ -4262,6 +4262,8 @@ static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name, 
{

	struct lan8814_shared_priv *shared = phy_package_get_priv(phydev);



	shared->phydev = phydev;



	/* Initialise shared lock for clock*/

	mutex_init(&shared->shared_lock);
@@ -4317,8 +4319,6 @@ static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name, 


	phydev_dbg(phydev, "successfully registered ptp clock\n");



	shared->phydev = phydev;



	/* The EP.4 is shared between all the PHYs in the package and also it

	 * can be accessed by any of the PHYs

	 */