Commit 39a9ed0f authored by Haofeng Li's avatar Haofeng Li Committed by Thomas Gleixner
Browse files

timekeeping: Fix aux clocks sysfs initialization loop bound 



The loop in tk_aux_sysfs_init() uses `i <= MAX_AUX_CLOCKS` as the
termination condition, which results in 9 iterations (i=0 to 8) when
MAX_AUX_CLOCKS is defined as 8. However, the kernel is designed to support
only up to 8 auxiliary clocks.

This off-by-one error causes the creation of a 9th sysfs entry that exceeds
the intended auxiliary clock range.

Fix the loop bound to use `i < MAX_AUX_CLOCKS` to ensure exactly 8
auxiliary clock entries are created, matching the design specification.

Fixes: 7b95663a ("timekeeping: Provide interface to control auxiliary clocks")
Signed-off-by: default avatarHaofeng Li <lihaofeng@kylinos.cn>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://patch.msgid.link/tencent_2376993D9FC06A3616A4F981B3DE1C599607@qq.com
parent 211ddde0

kernel/time/timekeeping.c

+1 −1
Original line number Diff line number Diff line
@@ -3070,7 +3070,7 @@ static int __init tk_aux_sysfs_init(void) 
		return -ENOMEM;

	}



	for (int i = 0; i <= MAX_AUX_CLOCKS; i++) {

	for (int i = 0; i < MAX_AUX_CLOCKS; i++) {

		char id[2] = { [0] = '0' + i, };

		struct kobject *clk = kobject_create_and_add(id, auxo);