Commit 39b0a10d authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: stmmac: remove unnecessary stmmac_mac_set() in stmmac_release() 



stmmac_release() calls phylink_stop() and then goes on to call
stmmac_mac_set(, false). However, phylink_stop() will call
stmmac_mac_link_down() before returning, which will do this work.
Remove this unnecessary call.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Tested-by: default avatarFurong Xu <0x1207@gmail.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1trcI6-005rn8-GV@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 180fa8d0

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+0 −3
Original line number Diff line number Diff line
@@ -4129,9 +4129,6 @@ static int stmmac_release(struct net_device *dev) 
	/* Release and free the Rx/Tx resources */

	free_dma_desc_resources(priv, &priv->dma_conf);



	/* Disable the MAC Rx/Tx */

	stmmac_mac_set(priv, priv->ioaddr, false);



	/* Powerdown Serdes if there is */

	if (priv->plat->serdes_powerdown)

		priv->plat->serdes_powerdown(dev, priv->plat->bsp_priv);