Commit 39b13dce authored by Su Hui's avatar Su Hui Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Fix the double free in scmi_debugfs_common_setup() 



Clang static checker(scan-build) throws below warning：
  |  drivers/firmware/arm_scmi/driver.c:line 2915, column 2
  |        Attempt to free released memory.

When devm_add_action_or_reset() fails, scmi_debugfs_common_cleanup()
will run twice which causes double free of 'dbg->name'.

Remove the redundant scmi_debugfs_common_cleanup() to fix this problem.

Fixes: c3d4aed7 ("firmware: arm_scmi: Populate a common SCMI debugfs root")
Signed-off-by: default avatarSu Hui <suhui@nfschina.com>
Reviewed-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Message-Id: <20241011104001.1546476-1-suhui@nfschina.com>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 9852d85e

drivers/firmware/arm_scmi/driver.c

+1 −3
Original line number Diff line number Diff line
@@ -2976,10 +2976,8 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) 
	dbg->top_dentry = top_dentry;



	if (devm_add_action_or_reset(info->dev,

				     scmi_debugfs_common_cleanup, dbg)) {

		scmi_debugfs_common_cleanup(dbg);

				     scmi_debugfs_common_cleanup, dbg))

		return NULL;

	}



	return dbg;

}