Commit 39cdf87a authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki
Browse files

cpuidle: psci: Fix uninitialized variable in dt_idle_state_present() 



If the first cpu_node = of_cpu_device_node_get() fails then the cleanup.h
code will try to free "state_node" but it hasn't been initialized yet.
Declare the device_nodes where they are initialized to fix this.

Fixes: 5836ebeb ("cpuidle: psci: Avoid initializing faux device if no DT idle states are present")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aDVRcfU8O8sez1x7@stanley.mountain


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5836ebeb

drivers/cpuidle/cpuidle-psci.c

+4 −5
Original line number Diff line number Diff line
@@ -440,14 +440,13 @@ static struct faux_device_ops psci_cpuidle_ops = { 


static bool __init dt_idle_state_present(void)

{

	struct device_node *cpu_node __free(device_node);

	struct device_node *state_node __free(device_node);



	cpu_node = of_cpu_device_node_get(cpumask_first(cpu_possible_mask));

	struct device_node *cpu_node __free(device_node) =

			of_cpu_device_node_get(cpumask_first(cpu_possible_mask));

	if (!cpu_node)

		return false;



	state_node = of_get_cpu_state_node(cpu_node, 0);

	struct device_node *state_node __free(device_node) =

			of_get_cpu_state_node(cpu_node, 0);

	if (!state_node)

		return false;