Commit 39d86db3 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

loop: add file_start_write() and file_end_write() 



file_start_write() and file_end_write() should be added around ->write_iter().

Recently we switch to ->write_iter() from vfs_iter_write(), and the
implied file_start_write() and file_end_write() are lost.

Also we never add them for dio code path, so add them back for covering
both.

Cc: Jeff Moyer <jmoyer@redhat.com>
Fixes: f2fed441 ("loop: stop using vfs_iter_{read,write} for buffered I/O")
Fixes: bc07c10a ("block: loop: support DIO & AIO")
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20250527153405.837216-1-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 208c1559

drivers/block/loop.c

+6 −2
Original line number Diff line number Diff line
@@ -308,11 +308,14 @@ static void lo_complete_rq(struct request *rq) 
static void lo_rw_aio_do_completion(struct loop_cmd *cmd)

{

	struct request *rq = blk_mq_rq_from_pdu(cmd);

	struct loop_device *lo = rq->q->queuedata;



	if (!atomic_dec_and_test(&cmd->ref))

		return;

	kfree(cmd->bvec);

	cmd->bvec = NULL;

	if (req_op(rq) == REQ_OP_WRITE)

		file_end_write(lo->lo_backing_file);

	if (likely(!blk_should_fake_timeout(rq->q)))

		blk_mq_complete_request(rq);

}
@@ -387,9 +390,10 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, 
		cmd->iocb.ki_flags = 0;

	}



	if (rw == ITER_SOURCE)

	if (rw == ITER_SOURCE) {

		file_start_write(lo->lo_backing_file);

		ret = file->f_op->write_iter(&cmd->iocb, &iter);

	else

	} else

		ret = file->f_op->read_iter(&cmd->iocb, &iter);



	lo_rw_aio_do_completion(cmd);