Commit 39e912a9 authored by Jiasheng Jiang's avatar Jiasheng Jiang Committed by Jakub Kicinski
Browse files

dpll: Add an assertion to check freq_supported_num 



Since the driver is broken in the case that src->freq_supported is not
NULL but src->freq_supported_num is 0, add an assertion for it.

Signed-off-by: default avatarJiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Link: https://patch.msgid.link/20250228150210.34404-1-jiashengjiangcool@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a144da58

drivers/dpll/dpll_core.c

+4 −1
Original line number Diff line number Diff line
@@ -443,8 +443,11 @@ static void dpll_pin_prop_free(struct dpll_pin_properties *prop) 
static int dpll_pin_prop_dup(const struct dpll_pin_properties *src,

			     struct dpll_pin_properties *dst)

{

	if (WARN_ON(src->freq_supported && !src->freq_supported_num))

		return -EINVAL;



	memcpy(dst, src, sizeof(*dst));

	if (src->freq_supported && src->freq_supported_num) {

	if (src->freq_supported) {

		size_t freq_size = src->freq_supported_num *

				   sizeof(*src->freq_supported);

		dst->freq_supported = kmemdup(src->freq_supported,