Commit 3a03f9ec authored by Yu-Chun Lin's avatar Yu-Chun Lin Committed by Jakub Kicinski
Browse files

net: stmmac: Use str_enabled_disabled() helper 



As kernel test robot reported, the following warning occurs:

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:582:6-8: opportunity for str_enabled_disabled(on)

Replace ternary (condition ? "enabled" : "disabled") with
str_enabled_disabled() from string_choices.h to improve readability,
maintain uniform string usage, and reduce binary size through linker
deduplication.

Reviewed-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: default avatarYu-Chun Lin <eleanor15x@gmail.com>
Link: https://patch.msgid.link/20250217155833.3105775-1-eleanor15x@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8f02c48f

drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

+2 −1
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 
#include <linux/slab.h>

#include <linux/ethtool.h>

#include <linux/io.h>

#include <linux/string_choices.h>

#include "stmmac.h"

#include "stmmac_pcs.h"

#include "stmmac_ptp.h"
@@ -625,7 +626,7 @@ int dwmac1000_ptp_enable(struct ptp_clock_info *ptp, 
		}



		netdev_dbg(priv->dev, "Auxiliary Snapshot %s.\n",

			   on ? "enabled" : "disabled");

			   str_enabled_disabled(on));

		writel(tcr_val, ptpaddr + PTP_TCR);



		/* wait for auxts fifo clear to finish */