Commit 3a5fe930 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

sched/balancing: Fix comments (trying to) refer to NOHZ_BALANCE_KICK 



Fix two typos:

 - There's no such thing as 'nohz_balancing_kick', the
   flag is named 'BALANCE' and is capitalized:  NOHZ_BALANCE_KICK.

 - Likewise there's no such thing as a 'pending nohz_balance_kick'
   either, the NOHZ_BALANCE_KICK flag is all upper-case.

Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Reviewed-by: default avatarValentin Schneider <vschneid@redhat.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240308105901.1096078-8-mingo@kernel.org
parent be8858db

kernel/sched/fair.c

+4 −3
Original line number Diff line number Diff line
@@ -12409,15 +12409,16 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) 
}



/*

 * run_rebalance_domains is triggered when needed from the scheduler tick.

 * Also triggered for nohz idle balancing (with nohz_balancing_kick set).

 * This softirq may be triggered from the scheduler tick, or by

 * any of the flags in NOHZ_KICK_MASK: NOHZ_BALANCE_KICK,

 * NOHZ_STATS_KICK or NOHZ_NEXT_KICK.

 */

static __latent_entropy void run_rebalance_domains(struct softirq_action *h)

{

	struct rq *this_rq = this_rq();

	enum cpu_idle_type idle = this_rq->idle_balance;

	/*

	 * If this CPU has a pending nohz_balance_kick, then do the

	 * If this CPU has a pending NOHZ_BALANCE_KICK, then do the

	 * balancing on behalf of the other idle CPUs whose ticks are

	 * stopped. Do nohz_idle_balance *before* rebalance_domains to

	 * give the idle CPUs a chance to load balance. Else we may