Commit 3a63e444 authored Mar 13, 2006 by Adrian Bunk Committed by Jaroslav Kysela Mar 22, 2006

[ALSA] sound/core/: fix 3 off-by-one errors



Modules: ALSA Core

This patch fixes three off-by-one errors found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 64649400

sound/core/sound.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -121,7 +121,7 @@ void *snd_lookup_minor_data(unsigned int minor, int type)
		struct snd_minor *mreg;
		void *private_data;

		if (minor > ARRAY_SIZE(snd_minors))
		if (minor >= ARRAY_SIZE(snd_minors))
		return NULL;
		mutex_lock(&sound_mutex);
		mreg = snd_minors[minor];
		@@ -140,7 +140,7 @@ static int snd_open(struct inode inode, struct file file)
		struct file_operations *old_fops;
		int err = 0;

		if (minor > ARRAY_SIZE(snd_minors))
		if (minor >= ARRAY_SIZE(snd_minors))
		return -ENODEV;
		mptr = snd_minors[minor];
		if (mptr == NULL) {

sound/core/sound_oss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -46,7 +46,7 @@ void *snd_lookup_oss_minor_data(unsigned int minor, int type)
		struct snd_minor *mreg;
		void *private_data;

		if (minor > ARRAY_SIZE(snd_oss_minors))
		if (minor >= ARRAY_SIZE(snd_oss_minors))
		return NULL;
		mutex_lock(&sound_oss_mutex);
		mreg = snd_oss_minors[minor];