Commit 3aaf22b6 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/fdinfo: get rid of ref tryget 



The caller holds a reference to the ring itself, so by definition
the ring cannot go away. There's no need to play games with tryget
for the reference, as we don't need an extra reference at all.

Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9e4bef2b

io_uring/fdinfo.c

+6 −12
Original line number Diff line number Diff line
@@ -46,9 +46,13 @@ static __cold int io_uring_show_cred(struct seq_file *m, unsigned int id, 
	return 0;

}



static __cold void __io_uring_show_fdinfo(struct io_ring_ctx *ctx,

					  struct seq_file *m)

/*

 * Caller holds a reference to the file already, we don't need to do

 * anything else to get an extra reference.

 */

__cold void io_uring_show_fdinfo(struct seq_file *m, struct file *f)

{

	struct io_ring_ctx *ctx = f->private_data;

	struct io_sq_data *sq = NULL;

	struct io_overflow_cqe *ocqe;

	struct io_rings *r = ctx->rings;
@@ -203,14 +207,4 @@ static __cold void __io_uring_show_fdinfo(struct io_ring_ctx *ctx, 


	spin_unlock(&ctx->completion_lock);

}



__cold void io_uring_show_fdinfo(struct seq_file *m, struct file *f)

{

	struct io_ring_ctx *ctx = f->private_data;



	if (percpu_ref_tryget(&ctx->refs)) {

		__io_uring_show_fdinfo(ctx, m);

		percpu_ref_put(&ctx->refs);

	}

}

#endif