Commit 3ab659eb authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Ulf Hansson
Browse files

mmc: rtsx_usb_sdmmc: Fix clang -Wimplicit-fallthrough in sd_set_power_mode() 



Clang warns (or errors with CONFIG_WERROR=y):

  drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
   1042 |         case MMC_POWER_UNDEFINED:
        |         ^
  drivers/mmc/host/rtsx_usb_sdmmc.c:1042:2: note: insert 'break;' to avoid fall-through
   1042 |         case MMC_POWER_UNDEFINED:
        |         ^
        |         break;

Clang is a little more pedantic than GCC, which does not warn when
falling through to a case that is just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing break to silence
the warning.

Fixes: 2c3809bd6f65 ("mmc: rtsx_usb_sdmmc: Add 74 clocks in poweron flow")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20250620-mmc-rtsx-usb-sdmmc-fix-clang-implicit-fallthrough-v1-1-4031d11159c0@kernel.org


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent d783ce4f

drivers/mmc/host/rtsx_usb_sdmmc.c

+2 −0
Original line number Diff line number Diff line
@@ -1039,6 +1039,8 @@ static void sd_set_power_mode(struct rtsx_usb_sdmmc *host, 
	case MMC_POWER_ON:

		/* stop to send the clock signals */

		rtsx_usb_write_register(ucr, SD_BUS_STAT, SD_CLK_TOGGLE_EN, 0x00);

		break;



	case MMC_POWER_UNDEFINED:

		break;