Commit 3aecb2e7 authored by Xiaoyao Li's avatar Xiaoyao Li Committed by Dave Hansen
Browse files

x86/tdx: Fix the typo in TDX_ATTR_MIGRTABLE 



The TD scoped TDCS attributes are defined by bit positions. In the guest
side of the TDX code, the 'tdx_attributes' string array holds pretty
print names for these attributes, which are generated via macros and
defines. Today these pretty print names are only used to print the
attribute names to dmesg.

Unfortunately there is a typo in the define for the migratable bit.
Change the defines TDX_ATTR_MIGRTABLE* to TDX_ATTR_MIGRATABLE*. Update
the sole user, the tdx_attributes array, to use the fixed name.

Since these defines control the string printed to dmesg, the change is
user visible. But the risk of breakage is almost zero since it is not
exposed in any interface expected to be consumed programmatically.

Fixes: 564ea84c ("x86/tdx: Dump attributes and TD_CTLS on boot")
Signed-off-by: default avatarXiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: default avatarKai Huang <kai.huang@intel.com>
Acked-by: default avatarSean Christopherson <seanjc@google.com>
Link: https://patch.msgid.link/20260303030335.766779-2-xiaoyao.li@intel.com
parent b5425f54

arch/x86/coco/tdx/debug.c

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ static __initdata const char *tdx_attributes[] = { 
	DEF_TDX_ATTR_NAME(ICSSD),

	DEF_TDX_ATTR_NAME(LASS),

	DEF_TDX_ATTR_NAME(SEPT_VE_DISABLE),

	DEF_TDX_ATTR_NAME(MIGRTABLE),

	DEF_TDX_ATTR_NAME(MIGRATABLE),

	DEF_TDX_ATTR_NAME(PKS),

	DEF_TDX_ATTR_NAME(KL),

	DEF_TDX_ATTR_NAME(TPA),

arch/x86/include/asm/shared/tdx.h

+2 −2
Original line number Diff line number Diff line
@@ -35,8 +35,8 @@ 
#define TDX_ATTR_LASS			BIT_ULL(TDX_ATTR_LASS_BIT)

#define TDX_ATTR_SEPT_VE_DISABLE_BIT	28

#define TDX_ATTR_SEPT_VE_DISABLE	BIT_ULL(TDX_ATTR_SEPT_VE_DISABLE_BIT)

#define TDX_ATTR_MIGRTABLE_BIT		29

#define TDX_ATTR_MIGRTABLE		BIT_ULL(TDX_ATTR_MIGRTABLE_BIT)

#define TDX_ATTR_MIGRATABLE_BIT		29

#define TDX_ATTR_MIGRATABLE		BIT_ULL(TDX_ATTR_MIGRATABLE_BIT)

#define TDX_ATTR_PKS_BIT		30

#define TDX_ATTR_PKS			BIT_ULL(TDX_ATTR_PKS_BIT)

#define TDX_ATTR_KL_BIT			31