Commit 3b07bb90 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Boqun Feng
Browse files

leds: lp8860: Check return value of devm_mutex_init() 



devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
marked as unusable and trigger errors on usage.

Add the missed check.

Fixes: 87a59548 ("leds: lp8860: Use new mutex guards to cleanup function exits")
Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Acked-by: default avatarAndrew Davis <afd@ti.com>
Acked-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-2-d9e449f4d224@weissschuh.net
parent d24a54e0

drivers/leds/leds-lp8860.c

+3 −1
Original line number Diff line number Diff line
@@ -307,7 +307,9 @@ static int lp8860_probe(struct i2c_client *client) 
	led->client = client;

	led->led_dev.brightness_set_blocking = lp8860_brightness_set;



	devm_mutex_init(&client->dev, &led->lock);

	ret = devm_mutex_init(&client->dev, &led->lock);

	if (ret)

		return dev_err_probe(&client->dev, ret, "Failed to initialize lock\n");



	led->regmap = devm_regmap_init_i2c(client, &lp8860_regmap_config);

	if (IS_ERR(led->regmap)) {