Unverified Commit 3b0abc44 authored by Rohit Visavalia's avatar Rohit Visavalia Committed by Stephen Boyd
Browse files

clk: xilinx: vcu: unregister pll_post only if registered correctly 



If registration of pll_post is failed, it will be set to NULL or ERR,
unregistering same will fail with following call trace:

Unable to handle kernel NULL pointer dereference at virtual address 008
pc : clk_hw_unregister+0xc/0x20
lr : clk_hw_unregister_fixed_factor+0x18/0x30
sp : ffff800011923850
...
Call trace:
 clk_hw_unregister+0xc/0x20
 clk_hw_unregister_fixed_factor+0x18/0x30
 xvcu_unregister_clock_provider+0xcc/0xf4 [xlnx_vcu]
 xvcu_probe+0x2bc/0x53c [xlnx_vcu]

Fixes: 4472e184 ("soc: xilinx: vcu: make pll post divider explicit")
Signed-off-by: default avatarRohit Visavalia <rohit.visavalia@amd.com>
Link: https://lore.kernel.org/r/20250210113614.4149050-2-rohit.visavalia@amd.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 19272b37

drivers/clk/xilinx/xlnx_vcu.c

+2 −2
Original line number Diff line number Diff line
@@ -587,7 +587,7 @@ static void xvcu_unregister_clock_provider(struct xvcu_device *xvcu) 
		xvcu_clk_hw_unregister_leaf(hws[CLK_XVCU_ENC_MCU]);

	if (!IS_ERR_OR_NULL(hws[CLK_XVCU_ENC_CORE]))

		xvcu_clk_hw_unregister_leaf(hws[CLK_XVCU_ENC_CORE]);



	if (!IS_ERR_OR_NULL(xvcu->pll_post))

		clk_hw_unregister_fixed_factor(xvcu->pll_post);

}